[CRIU] [PATCH v4 14/17] cr-restore: new list of ns shared objects introduced

Pavel Emelyanov xemul at parallels.com
Tue Jan 19 07:49:49 PST 2016


On 01/19/2016 06:10 PM, Stanislav Kinsburskiy wrote:
> 
> 
> 19.01.2016 16:08, Pavel Emelyanov пишет:
>> On 01/07/2016 07:10 PM, Stanislav Kinsburskiy wrote:
>>> Autofs restore needs to create some shared data structures to be able to pass
>>> data to actual autofs master.
>>> But on mount restore stage shared data is not configured yet.
>>> This list of objects and their actors is processed after all mounts and shared
>>> data are restored to let autofs to create the objects.
>>>
>>> Signed-off-by: Stanislav Kinsburskiy <skinsbursky at virtuozzo.com>
>>> ---
>>>   cr-restore.c |   37 +++++++++++++++++++++++++++++++++++++
>>>   1 file changed, 37 insertions(+)
>>>
>>> diff --git a/cr-restore.c b/cr-restore.c
>>> index ea83b44..90b3c4c 100644
>>> --- a/cr-restore.c
>>> +++ b/cr-restore.c
>>> @@ -181,6 +181,39 @@ static struct collect_image_info *cinfos[] = {
>>>   	&file_locks_cinfo,
>>>   };
>>>   
>>> +struct shared_ns_object {
>> Strange name :)
> 
> Agreed. I'm not good in inventing names, so ready to accept any better.
> 
>>
>> Try to move tty_setup_slavery() and resolve_unix_peers() onto this.
> 
> Let's crate another task for this? It doesn't really related to subj, 
> and looks like an optimization.

Sure. Just don't put it on a long finger, this patch would show whether the proposed
abstraction is generic enough.



More information about the CRIU mailing list