[CRIU] [PATCH v4 05/17] autofs: parse fsinfo stage introduced

[Pavel Emelyanov]

On 01/19/2016 06:08 PM, Stanislav Kinsburskiy wrote:
> 
> 
> 19.01.2016 14:52, Pavel Emelyanov пишет:
>>> +static int parse_options(char *options, int32_t *fd, int32_t *timeout,
>>> +			 int32_t *minproto, int32_t *maxproto, int32_t *mode,
>>> +			 int32_t *pgrp, int32_t *uid, int32_t *gid,
>>> +			 long *pipe_ino)
>>> +{
>>> +	char **opts;
>>> +	int nr_opts, i;
>>> +
>>> +	*fd = AUTOFS_OPT_UNKNOWN;
>>> +	*timeout = AUTOFS_OPT_UNKNOWN;
>>> +	*minproto = AUTOFS_OPT_UNKNOWN;
>>> +	*maxproto = AUTOFS_OPT_UNKNOWN;
>>> +	*mode = AUTOFS_OPT_UNKNOWN;
>>> +	*pgrp = AUTOFS_OPT_UNKNOWN;
>>> +	*uid = AUTOFS_OPT_UNKNOWN;
>>> +	*gid = AUTOFS_OPT_UNKNOWN;
>>> +	*pipe_ino = AUTOFS_OPT_UNKNOWN;
>>> +
>>> +	split(options, ',', &opts, &nr_opts);
>>> +	if (!opts)
>>> +		return -1;
>>> +
>>> +	for (i = 0; i < nr_opts; i++) {
>>> +		char *opt = opts[i];
>>> +
>>> +		if (!strncmp(opt, "fd=", strlen("fd=")))
>>> +			*fd = atoi(opt + strlen("fd="));
>>> +		else if (!strncmp(opt, "pipe_ino=", strlen("pipe_ino=")))
>>> +			*pipe_ino = atoi(opt + strlen("pipe_ino="));
>> This is the new option you try(ed) to push upstream? What's the status
>> of this patch?
> 
> I got some response from maintainer (Ian Kent).
> You can find it here:
> 
> https://lists.openvz.org/pipermail/criu/2016-January/024748.html
> 
> In short, he is not familiar with CRIU. So I gave him some information 
> why we require new option and how CRIU works.
> He has nothing against, but requested for more time to think about how 
> to deliver this change to the upstream kernel.
> He also mentioned, that there is some project with converting 
> "fs/autofs4" into "fs/autofs", it's related to Al Viro.
> I think I'll ping him now once again.

OK. Keep track of required kernel change on this page:
http://criu.org/Upstream_kernel_commits