[CRIU] [PATCH v2 0/3] vzct: c/r kernel.core_pattern sysctl

Pavel Emelyanov xemul at virtuozzo.com
Mon Feb 29 01:03:20 PST 2016


On 02/26/2016 01:17 PM, Cyrill Gorcunov wrote:
> On Fri, Feb 26, 2016 at 01:06:21PM +0300, Pavel Tikhomirov wrote:
>>> So probably worth to think if some of arguments might be needed
>>> in future?
>>
>> To be able to pass data from criu to plugin and vice versa, we can use NULL
>> terminated (void *args[]) array to pass variable amount of arguments to
>> plugin hook. Other possibility is using va_arg for plugin functions. Please,
>> let me know which way is preferable. Or may be we have some other option?
> 
> Yes, I think va_arg might be better here. xemul@?

Plain va_args in plugins typically work poorly for compatibility reasons -- once
we add new arg the plugin has no idea how to "detect" its presence or absence.

-- Pavel



More information about the CRIU mailing list