[CRIU] [PATCH v2 0/3] vzct: c/r kernel.core_pattern sysctl

[Pavel Tikhomirov]

On 02/25/2016 10:32 PM, Cyrill Gorcunov wrote:
> On Thu, Feb 25, 2016 at 06:55:40PM +0300, Pavel Tikhomirov wrote:
>> Make our virtualized kernel.core_pattern properly c/r, thus
>> creating universal post-c/r plugin to c/r any custom props
>> for example Virtuozzo specitic staff with criu.
>>
>> We can reuse open_image_at, pb_read_one and pb_write_one in criu
>> plugin and save all custom props to vzct.img in protobuf format.
>>
>> One can reuse POST_DUMP, POST_RESTORE plugin hooks for own plugin, it
>> is not for VZCT plugin only, use it as alternative to action-scripts.
>>
>> https://bugs.openvz.org/browse/OVZ-6696
>> https://jira.sw.ru/browse/PSBM-44145
>>
>> v2: change hook names to general ones, fix test, add bug links
>>
>> Pavel Tikhomirov (3):
>>    plugin: add POST_DUMP and POST_RESTORE hooks to c/r custom properties
>>    plugin: VZCT c/r core_pattern in CT
>>    test: VZCT plugin should c/r VZ7CT kernel.core_pattern sysctl
>
> While I like it in general there only one question remains -- should
> we provide some additional arguments to plugin functions? Currently
> they are void and once we commit them we can't change them anymore.
> So probably worth to think if some of arguments might be needed
> in future?

To be able to pass data from criu to plugin and vice versa, we can use 
NULL terminated (void *args[]) array to pass variable amount of 
arguments to plugin hook. Other possibility is using va_arg for plugin 
functions. Please, let me know which way is preferable. Or may be we 
have some other option?

>

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.