[CRIU] [PATCH] nmk: remove no-print-directory from MAKEFLAGS

Cyrill Gorcunov gorcunov at gmail.com
Thu Feb 25 14:44:04 PST 2016


On Thu, Feb 25, 2016 at 02:36:13PM -0800, Kir Kolyshkin wrote:
> The problem with --no-print-directory set by default is when we
> run :make from vim and compilation performed by a sub-make fails,
> vim can't figure out the correct path to a file with error, so
> instead of jumping to the position of the first error, it opens
> a new empty file.
> 
> When make prints "Entering directory ..." and "Leaving directory ..."
> messages, vim :make works as intended.
> 
> [Alternatively, we could add -w to $(MAKE) invocations where needed,
> but the problem is --no-print-directory overrides -w even if -w comes
> later in the options list, so -w is not working. I was also thinking
> about detecting whether we are running from vim, but when we'll need
> to add detection for emacs etc., so let's keep things simple.]
> 
> Cc: Andrey Vagin <avagin at openvz.org>
> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
> Signed-off-by: Kir Kolyshkin <kir at openvz.org>

The proper fix should be building criu from toplevel without
entering directories at all, but I lack spare time for this
task unfirtunately. So I can live with this patch for now,
but in longterm I should address the main inconvenience.

Reviewed-by: Cyrill Gorcunov <gorcunov at openvz.org>


More information about the CRIU mailing list