[CRIU] [PATCH 0/3] vzct: c/r kernel.core_pattern sysctl

Pavel Emelyanov xemul at virtuozzo.com
Thu Feb 25 02:40:03 PST 2016


On 02/25/2016 01:14 PM, Pavel Tikhomirov wrote:
> Pasha, except I will change plugin hook names to 
> CR_PLUGIN_HOOK__POST_DUMP CR_PLUGIN_HOOK__POST_RESTORE, 

Hm... Why are existing names bad?

> add jira link 

For _open_ jira, please.

> and remove unneeded line in test, is the patch Ok for you?

Yes, looks sane.

> On 02/19/2016 12:24 PM, Cyrill Gorcunov wrote:
>> On Thu, Feb 18, 2016 at 01:20:29PM +0300, Pavel Tikhomirov wrote:
>> ...
>>>
>>> Backporting to our stable branch is simple as:
>>> 1)mv images/vzct.proto protobuf/vzct.proto
>>> 2)change in test/vzct/vzct.c
>>> -#include "images/vzct.pb-c.h"
>>> +#include "protobuf/vzct.pb-c.h"
>>> 3)change in test/vzct/Makefile
>>> -       gcc -g -Werror -Wall -shared -nostartfiles vzct.c -o vzct.so -iquote
>>> ../../criu/include -iquote ../../ -iquote ../../criu/arch/x86/include -fPIC
>>> +       gcc -g -Werror -Wall -shared -nostartfiles vzct.c -o vzct.so -iquote
>>> ../../include -iquote ../../ -iquote ../../arch/x86/include -fPIC
>>> 4)change in protobuf-desc.c
>>> -#include "images/vzct.pb-c.h"
>>> +#include "protobuf/vzct.pb-c.h"
>>>
>>>>
>>>> Sounds good for you? xemul@?
>>
>> Except plugin entry point names the rest looks good for me.
>> But lets wait for Pavel's opinion.
>>
> 



More information about the CRIU mailing list