[CRIU] [PATCH] criu: cgroup -- Don't use PAGE_SIZE inside parasite args
Laurent Dufour
ldufour at linux.vnet.ibm.com
Thu Feb 25 01:48:20 PST 2016
On 25/02/2016 08:18, Cyrill Gorcunov wrote:
> This cause problem on ppc64
>
> | gcc -c -O2 -g -Wall -Werror -DCONFIG_PPC64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE
> | -fno-strict-aliasing -iquote /home/cyrill/criu/criu/include -iquote /home/cyrill/criu/images
> | -iquote /home/cyrill/criu/criu/pie -iquote /home/cyrill/criu/criu/arch/ppc64
> | -iquote /home/cyrill/criu/criu/arch/ppc64/include -iquote /home/cyrill/criu/ -I/usr/include/libnl3
> | -iquote ppc64 -DCONFIG_PPC64 -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE parasite-syscall.c -o parasite-syscall.o
> | parasite-syscall.c: In function ‘parasite_dump_cgroup’:
> | parasite-syscall.c:1283:2: error: size of unnamed array is negative
> | ca = parasite_args(ctl, struct parasite_dump_cgroup_args);
> | ^
> | /home/cyrill/criu/scripts/nmk/scripts/rules.mk:53: recipe for target 'parasite-syscall.o' failed
>
> Just use size parasite known to support.
>
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
Acked-by: Laurent Dufour <ldufour at linux.vnet.ibm.com>
This is better to not rely on PAGE_SIZE to size buffer since this could
be very large on some systems.
Thanks Cyrill,
Laurent.
More information about the CRIU
mailing list