[CRIU] [PATCH 2/6] Makefiles: don't use the FORCE, Luke!

Cyrill Gorcunov gorcunov at gmail.com
Wed Feb 24 11:00:00 PST 2016


On Wed, Feb 24, 2016 at 09:27:08PM +0300, Dmitry Safonov wrote:
> On 02/24/2016 09:08 PM, Kir Kolyshkin wrote:
> >
> >I don't like this style, two reasons are:
> >1. It doesn't add any clarity
> >2. When we use $(PHONY) for something else then defining phony targets,
> >such as
> >> all: $(PHONY)
> >in criu/Makefile and lib/Makefile, this becomes a mess as
> >say we can't use PHONY += clean in this case.
> >
> >So, I'd rather stick to the usual ".PHONY: targetname".
> >
> Ok, I don't have a strong opinion on that,
> just wanted it to be in the same code-style.

That was my bad in first place, guys. Lets stick
with explicit .PHONY: where needed. The $(PHONY)
make sence for debugging though but lets use
explicit ones. Thus, I vote for Kir. Sorry
if confused with my PHONY vars.


More information about the CRIU mailing list