[CRIU] [PATCH] criu: pie -- Zap parasite_dump_creds::gids

Cyrill Gorcunov gorcunov at openvz.org
Fri Feb 19 11:07:05 PST 2016


https://github.com/xemul/criu/issues/95

Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
---
 criu/pie/parasite.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/criu/pie/parasite.c b/criu/pie/parasite.c
index f946a2ba5b69..24666656e7e7 100644
--- a/criu/pie/parasite.c
+++ b/criu/pie/parasite.c
@@ -250,6 +250,16 @@ static int dump_creds(struct parasite_dump_creds *args)
 
 	args->uids[3] = sys_setfsuid(-1L);
 
+	/*
+	 * FIXME In https://github.com/xemul/criu/issues/95 it is
+	 * been reported that only low 16 bits are set upon syscall
+	 * on ARMv7.
+	 *
+	 * We may rather need implement builtin-memset and clear the
+	 * whole memory needed here.
+	 */
+	args->gids[0] = args->gids[1] = args->gids[2] = args->gids[3] = 0;
+
 	ret = sys_getresgid(&args->gids[0], &args->gids[1], &args->gids[2]);
 	if (ret) {
 		pr_err("Unable to get uids: %d\n", ret);
-- 
2.5.0



More information about the CRIU mailing list