[CRIU] Bringin back former syscalls

Tycho Andersen tycho.andersen at canonical.com
Fri Feb 19 08:06:47 PST 2016


Hi Cyrill,

On Fri, Feb 19, 2016 at 12:01:32PM +0300, Cyrill Gorcunov wrote:
> Hi Laurent! You know in commit 8ceab588a5ce9151375bc3d2a6d6637d758764ab
> we've been dropping off own __NR_ syscalls usage, which works quite
> fine for modern distros where all syscalls we're using maps to SYS_
> numbers from libc.
> 
> But it happen that we're running tests on old environments where
> libc is not that fresh ones and we got the cases like
> 
> cr-check.c: In function ‘check_kcmp’:
> cr-check.c:162:20: error: ‘SYS_kcmp’ undeclared (first use in this function)
> cr-check.c:162:20: note: each undeclared identifier is reported only once for each function it appears in
> cr-check.c: In function ‘check_prctl’:
> cr-check.c:206:26: error: ‘PR_SET_MM_EXE_FILE’ undeclared (first use in this function)
> cr-check.c:212:26: error: ‘PR_SET_MM_AUXV’ undeclared (first use in this function)
> make[2]: *** [cr-check.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [built-in.o] Error 2
> make: *** [criu] Error 2
> 
> (https://travis-ci.org/cyrillos/criu/jobs/110142700)
> 
> So I propose: either test all SYS_ entries on building stage via
> feature-tests helper, either revert the commit.
> 
> Could you please take a look in this area?

If this is just for travis (i.e. we don't care about people with
really old libcs as users), you can run travis on trusty now, which
has a libc that isn't from 2012 and hopefully (?) defines SYS_*. See
the attached patch.

Tycho
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-travis-run-tests-on-trusty-instead-of-precise.patch
Type: text/x-diff
Size: 836 bytes
Desc: not available
URL: <http://lists.openvz.org/pipermail/criu/attachments/20160219/d47ea9ca/attachment.bin>


More information about the CRIU mailing list