[CRIU] [PATCHv2 1/2] nmk/build: separate msg-* printing from .mk files

Cyrill Gorcunov gorcunov at gmail.com
Thu Feb 18 01:39:16 PST 2016


On Thu, Feb 18, 2016 at 12:34:55PM +0300, Dmitry Safonov wrote:
> On 02/18/2016 12:27 PM, Dmitry Safonov wrote:
> >On 02/17/2016 07:16 PM, Dmitry Safonov wrote:
> >>Some places in criu need printing support, but do not need
> >>common variables redefining, therefore separate msg printing
> >>to msg.mk
> >Oh, my inattention, Cyrill, please drop it, if you had
> >not applied it yet to your tree (will resend v3). Else fixup:
> >diff --git a/scripts/nmk/scripts/msg.mk b/scripts/nmk/scripts/msg.mk
> >index 255492c..a0279d0 100644
> >--- a/scripts/nmk/scripts/msg.mk
> >+++ b/scripts/nmk/scripts/msg.mk
> >@@ -42,4 +42,9 @@ define msg-build
> >         $(E) "  BUILD   " $(1)
> > endef
> >
> >+#
> >+# Footer.
> >+$(__nmk_dir)scripts/msg.mk:
> >+       @true
> >+____nmk_defined__msg = y
> > endif #____nmk_defined__msg
> Nothing bad should happen:
> just additional redefining the same variables the same way,
> but anyway.

Yeah this guards are not critical. I didn't picked it up
yet, waiting xemul@ to grab them first. There is an intention
to make scritps/nmk as a subtree of https://github.com/cyrillos/nmk


More information about the CRIU mailing list