[CRIU] [PATCH] nmk/build: separate msg-* printing from .mk files

Cyrill Gorcunov gorcunov at gmail.com
Wed Feb 17 07:49:28 PST 2016


On Wed, Feb 17, 2016 at 06:37:25PM +0300, Dmitry Safonov wrote:
> This patch fixes accidental dropping of msg-gen, msg-link messages.
> Just run make with another warn enabled:
> [criu]$ make --warn-undefined-variable 2>&1 | grep msg
>   PBCC     images/ipc-msg.pb-c.c
>   DEP      images/ipc-msg.pb-c.d
>   CC       images/ipc-msg.o
> Makefile.config:17: warning: undefined variable 'msg-gen'
> Makefile.version:20: warning: undefined variable 'msg-gen'
> Makefile:120: warning: undefined variable 'msg-link'
> Makefile:149: warning: undefined variable 'msg-link'
> Makefile:15: warning: undefined variable 'msg-gen'
> 
> All these messages seems to be missed.
> I think, for these places it's not needed to include full include.mk:
> it will compute SUBARCH and other not needed variables, wasting time.
> 
> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
> ---
>  criu/Makefile                   |  4 ++++
>  criu/Makefile.config            |  1 +
>  criu/Makefile.version           |  2 ++
>  lib/pycriu/images/Makefile      |  1 +
>  scripts/nmk/scripts/include.mk  | 42 ++------------------------------------
>  scripts/nmk/scripts/printmsg.mk | 45 +++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 55 insertions(+), 40 deletions(-)
>  create mode 100644 scripts/nmk/scripts/printmsg.mk

Please split it into two patches

1) nmk releated (and rename it to short msg.mk)
2) criu related

And put my ack same time. I'll grab nmk related stuff
into side tree as well.


More information about the CRIU mailing list