[CRIU] [PATCH] test/build: remove makefile built-in references

Cyrill Gorcunov gorcunov at gmail.com
Tue Feb 16 07:24:26 PST 2016


On Tue, Feb 16, 2016 at 06:12:58PM +0300, Dmitry Safonov wrote:
> As now we have in scripts/nmk/scripts/include.mk
> MAKEFLAGS, which contain -R flag, we should avoid using built-ins:
> (from man 1 make):
>        -R, --no-builtin-variables
>             Don't define any built-in variables.
> This patch removes references to COMPILE.c, OUTPUT_OPTION.
> I add CPPFLAGS to DEPEND.c which is needed to include
> arch/*/include/atomic.h file.
> 
> Note: after this patch `make test` still fails, as we need to
> convert built-in rules to defined rules from dependency files.
> (now still left to -include $(LIBDEP) which confuse make)
> 
> Cc: Cyrill Gorcunov <gorcunov at openvz.org>
> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
> ---
> Maybe I should use the new build process a little more in this patch.

Thanks a huge, Dima! I need to think about this. While I believe
it's correct way for zdtm inside CRIU, it's known that we're
running zdtm on its own (as a standalone framework) as far
as I remember for pcs7 testing. So maybe indeed we need to
find workaround to force "make test" operate as it were
before... Gimme a couple of hours.


More information about the CRIU mailing list