[CRIU] [PATCH 01/11] .gitignore -- Add back files to ignore

Dmitry Safonov dsafonov at virtuozzo.com
Tue Feb 16 01:29:34 PST 2016


On 02/15/2016 08:20 PM, Cyrill Gorcunov wrote:
> On Mon, Feb 15, 2016 at 08:04:01PM +0300, Dmitry Safonov wrote:
>> On 02/15/2016 07:52 PM, Cyrill Gorcunov wrote:
>>> On Mon, Feb 15, 2016 at 07:14:34PM +0300, Dmitry Safonov wrote:
>>>> On 02/15/2016 04:26 PM, Cyrill Gorcunov wrote:
>>>>> Have been removed while developing criu-2
>>>>> series, need to check that they are cleaned
>>>>> during "clean" stage.
>>>> Oh, BTW, do you have criu binary cleaned?
>>>> Here what I got:
>>> :-) I've did it explicitly in another patch.
>> Good. Thanks.
>> And another little nit: as you may see,
>> `make clean` prints the following line twice:
>>    CLEAN    pie
>> So, this:
>>> $(Q) $(MAKE) $(build)=pie $@
>> and this:
>>> $(Q) $(MAKE) $(call build-as,Makefile.library,pie) $@
>> Something seems unnecessary? (if I read correctly)
> No. They both are needed: $(build)=pie $@ cleans pie files
> which are not generated with pie/lib.a. Makefile.library
> cleans files which are used for pie/lib.a.
>
> IOW, pie splitted into two parts: lib.a which is needed
> for both: restorer and parasite, and the restorer and
> parasite itselves.
Oh, ok, thanks.
>
> Simply comment out this line and check and results.
>
> 	Cyrill


-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list