[CRIU] [PATCH 0/3] no more link crtools against the syscall lib

[Laurent Dufour]

On 08/02/2016 09:12, Cyrill Gorcunov wrote:
> On Fri, Feb 05, 2016 at 10:54:28PM +0300, Cyrill Gorcunov wrote:
>>> Laurent Dufour (3):
>>>   build: conditional define of struct prctl_mm_map
>>>   namespace: move definition of CLONE_SUBNS
>>>   crtools: no more linked with builtin syscall
>>
>> Reviewed-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>
>> Thanks a huge!
> 
> xemul@ reported
> 
>  | xemul: parasite-syscall.c: In function 'parasite_memfd_exchange':
>  | parasite-syscall.c:1199:28: error: '__NR_memfd_create' undeclared (first use in this function)
>  |  ret = syscall_seized(ctl, __NR_memfd_create, &sret,
> 
> 
> which initially comes from https://ci.openvz.org/job/CRIU-arm-build/27/console
> I think there is no __NR_memfd_create syscall number in system headers
> and when we've been using our own syscall library we've shipped the
> syscalls numbers same time, which is no longer the same once syscalls
> are thrown out.
> 
> Either we need to upgrade kernel headers on the test system, either
> revert the change (if only I don't miss something obvious).

Hi Cyrill,

Sorry for the late answer I'm sick currently and can't get focused on that.

In few words, I'd say that updating the kernel headers is a good option,
but I'll also send a patch which create a conditional define of
__NR_memfd_create, and remove it from the global syscall definition
since it is only used in parasite_syscall.c.

Cheers,
Laurent.