[CRIU] [PATCH 19/24] compel/Makefile: install to bin not sbin
Dmitry Safonov
0x7f454c46 at gmail.com
Tue Dec 20 01:50:12 PST 2016
2016-12-17 14:22 GMT+03:00 Kir Kolyshkin <kir at openvz.org>:
> compel tool doesn't need to be run as root, so it makes no sense
> to install it to SBINDIR. Fix to use BINDIR.
>
> Signed-off-by: Kir Kolyshkin <kir at openvz.org>
I think, we should also reflect this in changes log for release
when this will hit master - some scripts or anything may have
/sbin already coded for criu.
> ---
> compel/Makefile | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/compel/Makefile b/compel/Makefile
> index 670654e..8920281 100644
> --- a/compel/Makefile
> +++ b/compel/Makefile
> @@ -59,8 +59,8 @@ cleanup-y += compel/libcompel.so
>
> install: compel/compel compel/$(LIBCOMPEL_SO) compel/$(LIBCOMPEL_A)
> $(E) " INSTALL " compel
> - $(Q) mkdir -p $(DESTDIR)$(SBINDIR)
> - $(Q) install -m 755 compel/compel $(DESTDIR)$(SBINDIR)
> + $(Q) mkdir -p $(DESTDIR)$(BINDIR)
> + $(Q) install -m 755 compel/compel $(DESTDIR)$(BINDIR)
> $(E) " INSTALL " $(LIBCOMPEL_SO)
> $(Q) mkdir -p $(DESTDIR)$(LIBDIR)
> $(Q) install -m 0644 compel/$(LIBCOMPEL_SO) $(DESTDIR)$(LIBDIR)
> @@ -80,7 +80,7 @@ install: compel/compel compel/$(LIBCOMPEL_SO) compel/$(LIBCOMPEL_A)
>
> uninstall:
> $(E) " UNINSTALL" compel
> - $(Q) $(RM) $(addprefix $(DESTDIR)$(SBINDIR)/,compel)
> + $(Q) $(RM) $(addprefix $(DESTDIR)$(BINDIR)/,compel)
> $(E) " UNINSTALL" $(LIBCOMPEL_SO)
> $(Q) $(RM) $(addprefix $(DESTDIR)$(LIBDIR)/,$(LIBCOMPEL_SO))
> $(Q) $(RM) $(addprefix $(DESTDIR)$(LIBDIR)/,$(LIBCOMPEL_SO).$(COMPEL_SO_VERSION_MAJOR))
> --
> 2.7.4
>
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu
--
Dmitry
More information about the CRIU
mailing list