[CRIU] [PATCH 00/24] More polishing for compel cli

Kir Kolyshkin kir at openvz.org
Sat Dec 17 03:21:53 PST 2016


The aim of these patches is to improve compel cli usability.

1. To use compel,  one has to specify paths to compel tool itself,
to compel headers, to compel lib, and to compel plugins.
With this patchset, only the binary path is needed (and only
if compel is not installed, or installed in a non-standard path),
and the rest of information can be obtained from compel itself.

2. It appears that --arch option is not needed, as compel can only
be compiled for a specific architecture. Instead, --compat is
introduced to be used for 32-bit mode on x86 (maybe --compat
can also be dropped later, I still haven't figured it out).

3. As I worked with Makefiles, I made some changes, hopefully
to make them easier to work with.

4. Some minor stuff here and there.

Dmitry, Cyrill, please review.

Kir Kolyshkin (24):
  compel --help: fix indentation
  compel/test: Makefiles cleanup
  compel_syscall(): make ret argument signed
  compel/Makefile: rm unused .FORCE thing
  compel/src/main.c: rm useless init
  compel cli: kill --arch option, add --compat
  compel cli: print usage to stderr in case of error
  Makefile.install: rm trailing slash from instdirs
  compel cli: show includes
  Makefiles: rm -I compel/plugins... from cflags
  Makefiles: introduce/use COMPEL_BIN
  Makefile.compel: rm fds plugin
  compel: make include/uapi symlink permanent
  compel: make include/uapi/asm symlink permanent
  Makefile.compel: simplify compel-deps
  Makefile: untangle criu deps
  criu Makefiles: use compel includes
  compel cli: add linker script to ldflags / use it
  compel/Makefile: install to bin not sbin
  criu/pie/Makefile: a nitpick
  compel/test/infect/Makefile: fix a dependency
  compel cli: add plugins cmd, use it
  compel cli: add libs command, use it
  compel cli: make -p optional

 .gitignore                           |   2 +-
 Makefile                             |  17 ++-
 Makefile.compel                      |  35 ++---
 Makefile.install                     |   6 +-
 compel/Makefile                      |  21 +--
 compel/arch/aarch64/src/lib/infect.c |   4 +-
 compel/arch/arm/src/lib/infect.c     |   4 +-
 compel/arch/ppc64/src/lib/infect.c   |   4 +-
 compel/arch/x86/src/lib/infect.c     |   4 +-
 compel/compel-host                   |   8 +
 compel/include/infect-priv.h         |   2 +-
 compel/include/uapi/asm              |   1 +
 compel/include/uapi/compel           |   1 +
 compel/include/uapi/infect.h         |   2 +-
 compel/plugins/Makefile              |   2 -
 compel/src/lib/infect.c              |   4 +-
 compel/src/main.c                    | 286 ++++++++++++++++++++++++++---------
 compel/test/infect/Makefile          |  27 ++--
 compel/test/rsys/Makefile            |  16 +-
 criu/Makefile                        |  11 +-
 criu/Makefile.crtools                |   3 +-
 criu/arch/aarch64/Makefile           |   3 +-
 criu/arch/arm/Makefile               |   3 +-
 criu/arch/ppc64/Makefile             |   3 +-
 criu/arch/x86/Makefile               |   3 +-
 criu/pie/Makefile                    |  23 +--
 criu/pie/Makefile.library            |   3 +-
 27 files changed, 314 insertions(+), 184 deletions(-)
 create mode 100755 compel/compel-host
 create mode 120000 compel/include/uapi/asm
 create mode 120000 compel/include/uapi/compel

-- 
2.7.4



More information about the CRIU mailing list