[CRIU] [PATCH] zdtm: Add sock_peercred test

Kirill Tkhai ktkhai at virtuozzo.com
Thu Dec 15 03:58:29 PST 2016


On 15.12.2016 14:51, Pavel Emelyanov wrote:
> On 12/15/2016 02:38 PM, Kirill Tkhai wrote:
>>
>>
>> On 15.12.2016 14:34, Dmitry Safonov wrote:
>>> 2016-12-15 13:32 GMT+03:00 Kirill Tkhai <ktkhai at virtuozzo.com>:
>>>> On 15.12.2016 11:38, Pavel Emelyanov wrote:
>>>>> On 12/14/2016 08:32 PM, Kirill Tkhai wrote:
>>>>>> Check that SO_PEERCRED socket options restored correctly.
>>>>>> Now it's not supported, thus test is marked as "noauto".
>>>>>
>>>>> If test fails it should be marked with 'crfail' :)
>>>>
>>>> "crfail noauto" OR just "crfail"?
>>>
>>> Looks like only `crfail':
>>
>> Hm, I tried crfail only, and it failed travis tests:
>>
>> https://travis-ci.org/tkhai/criu/jobs/184196083
> 
> That's because crfail means -- dump should fail. Not result check should fail.

Ok, then we do not need crfail in this test, because every unix socket has peercreds,
and we would have to fail every dump, where a unix socket exists :)
Current test flags are correct.

>>> commit 2a835eb8d159
>>> Author: Andrew Vagin <avagin at virtuozzo.com>
>>> Date:   Fri Jun 10 00:09:00 2016 +0300
>>>
>>>     zdtm: remove or replace noauto on crfail where it's possiable
>>>
>>>
>>>>
>>>>>> (It seems support of this feature will require "ghost tasks",
>>>>>> when we introduce them).
>>>
>> .
>>
> 


More information about the CRIU mailing list