[CRIU] criu dump fails when using noxsave

[Cyrill Gorcunov]

On Thu, Dec 15, 2016 at 09:17:23AM +0100, Adrian Reber wrote:
> On Thu, Dec 15, 2016 at 01:37:55AM +0300, Cyrill Gorcunov wrote:
> > On Wed, Dec 14, 2016 at 11:07:24PM +0100, Adrian Reber wrote:
> > > I have two systems. One has the CPU feature xsave the other host
> > > doesn't.
> > > 
> > > To migrate processes between these systems I specified the kernel
> > > command-line 'noxsave' to disable the xsave option. With this kernel
> > > command-line criu fails to dump with:
> > > 
> > 
> > Hi! Thanks for report! It's night here will take a look tomorrow, ok?
> 
> I looked a bit more at XSAVE and wrote a simple test program to read out
> the features:
> 
> On a system where the CPU (KVM) has no XSAVE I get:
> 
> XSAVE: 0
> OSXSAVE: 0
> 
> On a system where the CPU has XSAVE and it is not disabled I get:
> 
> XSAVE: 1
> OSXSAVE: 1
> 
> On a system where the CPU has XSAVE but the kernel parameter noxsave is
> specified I get:
> 
> XSAVE: 1
> OSXSAVE: 0
> 
> Attached patch is what helps me to migrate a process from a XSAVE system
> booted with 'noxsave' to system without XSAVE. I will submit a proper
> patch soon.

Hi! Yes, we shold operate with osxsave bit instead of plain xsave.
The patch looks correct to me, thanks!