[CRIU] [PATCH v4 00/33] Rework file opening scheme to make it asynchronous

[Kirill Tkhai]

On 14.12.2016 12:33, Pavel Emelyanov wrote:
> On 12/14/2016 12:24 PM, Kirill Tkhai wrote:
>>
>>
>> On 14.12.2016 12:27, Pavel Emelyanov wrote:
>>> On 12/14/2016 11:37 AM, Kirill Tkhai wrote:
>>>> On 14.12.2016 11:04, Pavel Emelyanov wrote:
>>>>> On 12/13/2016 06:04 PM, Kirill Tkhai wrote:
>>>>>> Hi,
>>>>>>
>>>>>> this is v4 iteration of the patchset. There are changes in:
>>>>>>
>>>>>> 1)"[25/33]files: Make recv_fd_from_peer() non-block"
>>>>>>
>>>>>>   Fixed new_fd assignment error. Found by wathing.
>>>>>>
>>>>>> 2)"[26/33]files: Kill struct file_desc_ops::post_open"
>>>>>>
>>>>>>   Fixed a couple of errors found by unix exhaustive test and watching.
>>>>>
>>>>> What the error was?
>>>>
>>>> There were directly called ex-post_open callbacks, while a fd should firstly be reopened.
>>>> So, now I return ORV_AGAIN after first open to force generic code reopen it.
>>>
>>> So ->open is called twice?
>>
>> In case of unix sockets it's called twice only for standalone ones.
> 
> ->open? :( It's not cool. OK, I'll check the patches.
 
I may change that by direct calling of setup_and_serve_out() from unix open,
if you want..