[CRIU] [PATCH] Makefile.install: DESTDIR should be empty

Kir Kolyshkin kir at openvz.org
Tue Dec 13 18:19:46 PST 2016


DESTDIR is mostly used by packagers (such as from rpm spec
or deb rules), or just to try installation, and normally
should be left unset/empty.

Setting it to / looks weird to me. Besides, by leaving it empty
we are making sure everything works if DESTDIR is not set.

Fix INSTALL.md accordingly.

CC: Cyrill Gorcunov <gorcunov at openvz.org>
Signed-off-by: Kir Kolyshkin <kir at openvz.org>
---
 INSTALL.md       | 2 +-
 Makefile.install | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/INSTALL.md b/INSTALL.md
index 09c1911..7a545e8 100644
--- a/INSTALL.md
+++ b/INSTALL.md
@@ -8,7 +8,7 @@ and etc) simply typing
 
 this command accepts the following variables:
 
- * **DESTDIR**, to specify global root where all components will be placed under (`/` by default);
+ * **DESTDIR**, to specify global root where all components will be placed under (empty by default);
  * **PREFIX**, to specify additional prefix for path of every component installed (`/usr/local` by default);
  * **BINDIR**, to specify where to put CRIT tool (`$(PREFIX)/bin` by default);
  * **SBINDIR**, to specify where to put CRIU executable (`$(PREFIX)/sbin` by default);
diff --git a/Makefile.install b/Makefile.install
index 9e45e0e..cf7a2a6 100644
--- a/Makefile.install
+++ b/Makefile.install
@@ -1,6 +1,5 @@
 #
 # Installation paths.
-DESTDIR		?= /
 PREFIX		?= /usr/local
 BINDIR		?= $(PREFIX)/bin
 SBINDIR		?= $(PREFIX)/sbin
-- 
2.7.4



More information about the CRIU mailing list