[CRIU] [PATCH 0/4] RFC: simplify compel api

Cyrill Gorcunov gorcunov at gmail.com
Wed Dec 7 13:01:52 PST 2016


On Wed, Dec 07, 2016 at 12:20:05PM -0800, Kir Kolyshkin wrote:
> On 12/07/2016 12:48 AM, Cyrill Gorcunov wrote:
> > On Tue, Dec 06, 2016 at 03:54:25PM -0800, Kir Kolyshkin wrote:
> > > This is my weak attempt to simplify the compel api and usage.
> > > It's not finished yet, so not aimed for inclusion, but rather
> > > for review and comments.
> > I like it from a glance! Will review more precisely at the evening
> > but looks good for me.
> 
> Well, this currently breaks arm builds as for arm arches gen-offsets.sh
> is used instead of "compel hgen", and I haven't patched gen-offsets.sh.
> 
> Two possible ways are:
>  1. switch arm to use compel hgen like the rest of the arches
>  2. patch gen-offsets.h
> 
> Obviously #2 is way easier, but seems like #1 is right as otherwise compel
> is unusable as a stand-alone tool for ARM.
> 
> Any comments or suggestions?

First two patches seems safe, right? If so lets merge them
and then you can work on 1 without a rush.


More information about the CRIU mailing list