[CRIU] [PATCH 0/3] zdtm.py: Implement testing CRIU's RPC

[Pavel Emelyanov]

On 08/25/2016 11:53 PM, Ruslan Kuprieiev wrote:
> Hi,
> 
> Long gone Ruslan here =),
> 
> I think our APIs(CLI, C, Py) and their consistency should be tested 
> separately somehow,

:( Yes, yes...

> to assure that all of them produce equal criu options.

Hm... That's nice guess, but I'm trying to remind whether each option results
in some change on opts... Looks like yes.

> The easiest way to test them all,
> that comes to my mind, is to create a bunch of tests that will use APIs 
> and then make
> criu dump cr_options structure(the one from include/cr_options.h) for 
> further analysis,
> making sure that same logical action in all kinds of APIs produces same 
> cr_options.
> What do you think?

Yes, that sounds like a plan. And this would allow us not to forget adding
necessary API bits to all APIs, not just CLI.

> Current patch set essentially does something similar to what i 
> described(it transforms
> cli options into py), but it uses zdtm test which, to my knowledge, was 
> not intended to
> test apis consistency. That being said, it is definitely better than 
> nothing =).
> 
> 
> On 08/24/2016 04:20 PM, Pavel Emelyanov wrote:
>> So, in zdtm.py we run criu as CLI tool using python's subprocess.Popen
>> facility. With this the RPC part of the API is completely untested, so
>> let's try to improve that. Here's the --rpc option for zdtm.py that
>> spawns CRIU in swrk mode instead of CLI.
>>
>> However, there's a question -- what are the suggestions about how to
>> integrate this in CI? Apparently we cannot afford duplicating all the
>> jobs with --rpc option %)
>>
>> -- Pavel
>> _______________________________________________
>> CRIU mailing list
>> CRIU at openvz.org
>> https://lists.openvz.org/mailman/listinfo/criu
> 
> .
>