[CRIU] [PATCH] travis: catch core dump files in error cases

Andrei Vagin avagin at virtuozzo.com
Wed Aug 24 13:07:32 PDT 2016


> > @@ -1242,6 +1262,8 @@ class launcher:
> >  
> >  	def finish(self):
> >  		self.__wait_all()
> > +		if not opts['fault'] and check_core_files():
> 
> Why not for faults? Just curious :)

In a few cases we call BUG() in a fault case and a core file will be
generated.
For example:
        if (fault_injected(FI_DUMP_EARLY)) {
                pr_info("fault: CRIU sudden detach\n");
                BUG();
        }


> 
> > +			self.__fail = True
> 
> O_o  Can it happen that we have cores, but __fail is not set?

We don't check exit codes of tests processes, because they are
daemonized. So the answer is yes.
> 
> >  		if self.__file_report:
> >  			self.__file_report.close()
> >  		if self.__fail:
> > 
> 


More information about the CRIU mailing list