[CRIU] [PATCH 1/2] pstree: Make restore_finish_stage helper to use holder variable

[Cyrill Gorcunov]

On Wed, Aug 24, 2016 at 01:52:39PM +0300, Dmitry Safonov wrote:
> On 08/24/2016 01:32 PM, Cyrill Gorcunov wrote:
> > The @task_entries variable is declared as external in
> > criu/include/pstree.h and restore_finish_stage refers
> > to it implicitly. This is a bad habbit because the name
> > get propagated into pie code where we have a local
> > static variable, which eventually may shadow the former
> > copy with gcc 4.9 series as been reported by Nikolay.
> > 
> > Lets make restore_finish_stage helper to take variable
> > name explicitly.
> > 
> > Reported-by: Nikolay Borisov <kernel at kyup.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > ---
> 
> So, did the patches set fix restore? Just curious, as there is no
> tested-by.
> Anyway, looks good for me,
> Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>

Yes. We've been talking with Nikolay, the similar fixes for 2.5.
Once time permit he will test the criu-dev as well.