[CRIU] [PATCH 02/11] images: sk-packet -- Reserve data for netlink queue support

Andrey Vagin avagin at virtuozzo.com
Fri Aug 5 11:40:54 PDT 2016


On Thu, Aug 04, 2016 at 05:02:03PM +0300, Cyrill Gorcunov wrote:
> On Thu, Aug 04, 2016 at 04:59:54PM +0300, Pavel Emelyanov wrote:
> > On 08/02/2016 06:34 PM, Cyrill Gorcunov wrote:
> > > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > > ---
> > >  images/sk-packet.proto | 3 +++
> > >  1 file changed, 3 insertions(+)
> > > 
> > > diff --git a/images/sk-packet.proto b/images/sk-packet.proto
> > > index 5f61c73763fe..c6b5cef06bce 100644
> > > --- a/images/sk-packet.proto
> > > +++ b/images/sk-packet.proto
> > > @@ -3,4 +3,7 @@ syntax = "proto2";
> > >  message sk_packet_entry {
> > >  	required uint32		id_for		= 1;
> > >  	required uint32		length		= 2;
> > > +
> > > +	/* Reserve for netlink queue support */
> > > +	optional bytes		addr		= 3;
> > 
> > What is this? A sender identifier? If yes, please, align this with
> > Kirill Tkhai's patches that keep sender ID for unix sockets.
> 
> IIRC it's an address of message in memory. Andrew did it. Andrew?

It isn't enough to save only id for netlink sockets:

struct sockaddr_nl {
        __kernel_sa_family_t    nl_family;      /* AF_NETLINK   */
        unsigned short  nl_pad;         /* zero         */
        __u32           nl_pid;         /* port ID      */
        __u32           nl_groups;      /* multicast groups mask */
};



More information about the CRIU mailing list