[CRIU] [PATCH 01/12] soccr: Wire into builder (v2)

Dmitry Safonov dsafonov at virtuozzo.com
Fri Aug 5 08:32:19 PDT 2016


On 08/05/2016 05:58 PM, Pavel Emelyanov wrote:
> For now build the .a library not to produce criu wrappers.
> Next version should include the .so library as well.
>
> Signed-off-by: Pavel Emelyanov <xemul at virtuozzo.com>
> ---
[...]
> diff --git a/scripts/nmk/scripts/tools.mk b/scripts/nmk/scripts/tools.mk
> index 0538dde..b1d260c 100644
> --- a/scripts/nmk/scripts/tools.mk
> +++ b/scripts/nmk/scripts/tools.mk
> @@ -3,6 +3,7 @@ ifndef ____nmk_defined__tools
>  #
>  # System tools shorthands
>  RM		:= rm -f
> +CP		:= cp
>  LD		:= $(CROSS_COMPILE)ld
>  CC		:= $(CROSS_COMPILE)gcc
>  CPP		:= $(CC) -E

Don't have any objection about the patch, only small nit:
It's handy if changes for /scripts/nmk/* are in the separate patches.
AFAIK, Cyrill handle his mirror of nmk build engine for other projects,
so applying separate patches on NMK is easier. Especially, if they don't
break something in CRIU and can be applied separately.

Thanks, just dropping a note.


More information about the CRIU mailing list