[CRIU] [PATCH resend v7 00/14] net/ipv6: c/r dev/default/all conf ops

[Pavel Tikhomirov]

On 04/26/2016 10:42 PM, Andrew Vagin wrote:
> On Tue, Apr 26, 2016 at 03:13:40PM +0300, Pavel Tikhomirov wrote:
>> * resend v7 to make patchwork happy
>
> He needs more fun to be happy;)

 From log:
19:10:43.799:     5: FAIL: netns-dev.c:264: Option 
"/proc/sys/net/ipv6/conf/lo/mldv1_unsolicited_report_interval" changed 
from 135188171 to 135188172 (errno = 2 (No such file or directory))

I think in Travis environment someone or something increments(1 to 5 
times in different runs) mldv1_unsolicited_report_interval and thus 
breaks the test(small change in value is too suspicious). But I'm not 
sure how to reproduce the environment locally, is there a common way?

See the same behavior for test run with "--nocr" below, test fails 
without c/r'ing it.
https://travis-ci.org/Snorch/criu/jobs/125944022

21:00:54.226:     5: FAIL: netns-dev.c:264: Option 
"/proc/sys/net/ipv6/conf/lo/mldv1_unsolicited_report_interval" changed 
from 39342981 to 39342984 (errno = 2 (No such file or directory))

>
> https://zdtm.openvz.org/series/6/
> https://travis-ci.org/criupatchwork/criu/builds/125916987
>
>
>>
>> These patch set introduces support of another part of network
>> sysctls, now for ipv6.
>>
>> Most important things:
>> - DEVCONFS_UNUSED=-1 is wrong, use SysctlEntrys to track unused
>> sysctls
>> - mtu, forwarding, disable_ipv6 need special care on restore and in
>> tests
>> - add ranges for sysctl values in tests instead of just one limit,
>> also fix ranges for some sysctls
>>
>> Changes:
>>
>> v2: add SysctlEntrys, now can save string sysctls and easier handle unused
>>
>> v3: rebase images/Makefile to criu-dev branch
>>
>> v4: use CTL_FLAGS_HAS, use enum for SysctlEntry.type
>>
>> v5: use CTL_TYPE in sysctl_entries_equal
>>
>> v6: fix "sysctl: add CTL_FLAGS_HAS to mark successful sysctl_op request"
>> compilation, net_conf_op: manage non-existing string and fix wrong
>> sysctl_op arg for string, add rconf.
>>
>> v7: allow EIO on do_sysctl_op for optional sysctls, fix sysctl
>> file to close in error path, add test for stable_secret
>>
>> https://jira.sw.ru/browse/PSBM-30942
>>
>> Pavel Tikhomirov (14):
>>    sysctl: add CTL_FLAGS_HAS to mark successful sysctl_op request
>>    protobuf: add SysctlEntry for ipv4/ipv6 sysctl confs or some others
>>    net/ipv4: add net_conf_op to reuse for ipv6
>>    net/ipv6/protobuf: add device config options for ipv6
>>    net/ipv6: add devconfs6 array to store config option's names
>>    dump/net/ipv6: net device and def/all configuration
>>    restore/net/ipv6: net device and def/all configuration
>>    zdtm/net/ipv4: make save_and_set and check_and_restore reusable
>>    zdtm/net/ipv4: replace rand limits with rand ranges
>>    zdtm/net/ipv4: split save_and_set and check_and_restore
>>    zdtm/net/ipv6: add devconfs6 and rand_range6
>>    zdtm/net/ipv6: add test for confs
>>    sysctl: fix allocation for array of pointers
>>    zdtm/net/ipv6: add test for string stable_secret
>>
>>   criu/include/sysctl.h        |   1 +
>>   criu/net.c                   | 386 ++++++++++++++++++++++++++++++++++++++-----
>>   criu/sysctl.c                |  23 ++-
>>   images/Makefile              |   1 +
>>   images/netdev.proto          |  11 ++
>>   images/sysctl.proto          |  11 ++
>>   test/zdtm/static/netns-dev.c | 379 +++++++++++++++++++++++++++++++++++-------
>>   7 files changed, 700 insertions(+), 112 deletions(-)
>>   create mode 100644 images/sysctl.proto
>>
>> --
>> 2.4.11
>>