[CRIU] [PATCH v6 00/13] net/ipv6: c/r dev/default/all conf ops

[Andrew Vagin]

Have you run tests?

======================== Run zdtm/static/loginuid in ns ========================
Construct root for zdtm/static/loginuid
Start test
./loginuid --pidfile=loginuid.pid --outfile=loginuid.out
Run criu dump
=[log]=> dump/zdtm/static/loginuid/53/1/dump.log
------------------------ grep Error ------------------------
(00.039487) Error (sysctl.c:135): Can't read net/ipv6/conf/default/stable_secret: Input/output error
(00.039509) Error (net.c:223): Failed to read default/<confs>
(00.042986) Error (namespaces.c:1058): Namespaces dumping finished with error 65280
(00.057119) Error (cr-dump.c:1614): Dumping FAILED.
------------------------ ERROR OVER ------------------------
################# Test zdtm/static/loginuid FAIL at CRIU dump ##################
Wait for zdtm/static/loginuid to die for 0.100000

https://ci.openvz.org/job/CRIU/job/criu-patchwork/62/console


On Mon, Apr 25, 2016 at 05:56:41PM +0300, Pavel Tikhomirov wrote:
> These patch set introduces support of another part of network
> sysctls, now for ipv6.
> 
> Most important things:
> - DEVCONFS_UNUSED=-1 is wrong, use SysctlEntrys to track unused 
> sysctls
> - mtu, forwarding, disable_ipv6 need special care on restore and in
> tests
> - add ranges for sysctl values in tests instead of just one limit,
> also fix ranges for some sysctls
> 
> Changes:
> 
> v2: add SysctlEntrys, now can save string sysctls and easier handle unused
> 
> v3: rebase images/Makefile to criu-dev branch
> 
> v4: use CTL_FLAGS_HAS, use enum for SysctlEntry.type
> 
> v5: use CTL_TYPE in sysctl_entries_equal
> 
> v6: fix "sysctl: add CTL_FLAGS_HAS to mark successful sysctl_op request"
> compilation, net_conf_op: manage non-existing string and fix wrong
> sysctl_op arg for string, add rconf.
> 
> https://jira.sw.ru/browse/PSBM-30942
> 
> Pavel Tikhomirov (13):
>   sysctl: add CTL_FLAGS_HAS to mark successful sysctl_op request
>   protobuf: add SysctlEntry for ipv4/ipv6 sysctl confs or some others
>   net/ipv4: add net_conf_op to reuse for ipv6
>   net/ipv6/protobuf: add device config options for ipv6
>   net/ipv6: add devconfs6 array to store config option's names
>   dump/net/ipv6: net device and def/all configuration
>   restore/net/ipv6: net device and def/all configuration
>   zdtm/net/ipv4: make save_and_set and check_and_restore reusable
>   zdtm/net/ipv4: replace rand limits with rand ranges
>   zdtm/net/ipv4: split save_and_set and check_and_restore
>   zdtm/net/ipv6: add devconfs6 and rand_range6
>   zdtm/net/ipv6: add test for confs
>   sysctl: fix sysctl file to close in error path
> 
>  criu/include/sysctl.h        |   1 +
>  criu/net.c                   | 386 ++++++++++++++++++++++++++++++++++++++-----
>  criu/sysctl.c                |   8 +-
>  images/Makefile              |   1 +
>  images/netdev.proto          |  11 ++
>  images/sysctl.proto          |  11 ++
>  test/zdtm/static/netns-dev.c | 292 +++++++++++++++++++++++++-------
>  7 files changed, 602 insertions(+), 108 deletions(-)
>  create mode 100644 images/sysctl.proto
> 
> -- 
> 1.9.3
> 
> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu