[CRIU] [PATCH 0/2] build: Implement uninstall action

Dmitry Safonov dsafonov at virtuozzo.com
Fri Apr 22 12:03:40 PDT 2016


On 04/22/2016 05:41 PM, Pavel Emelyanov wrote:
> OK, applied.
>
> Please, add help text as Dima suggests and add recently added autofs scripts to uninstall :)

Hmm, I have a little strange idea: we might add some
test for that. Not to miss some install changes to unistall
target we could do:
1. install_dir=$(mktemp -d)
2. make install PREFIX=$(install_dir)
3. make uninstall PREFIX=$(install_dir)
4. find $(install_dir) -type f -not -name '*.py'
5. yell if anything found.

I'm not really sure, but we might also add some other
tests for buildsystem itself.
Like that `make clean` cleans all after tests, (recent)
that pie was relocated, that .gitignore is up-to-date.
(pie relocation we will see on real tests, but that will
fast return the answer, without debug)
Or any other fails of buildsystem that we met.
Should we?

-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list