[CRIU] [PATCH 0/2] build: Implement uninstall action

Dmitry Safonov dsafonov at virtuozzo.com
Fri Apr 22 06:45:36 PDT 2016


On 04/22/2016 04:41 PM, Cyrill Gorcunov wrote:
> On Fri, Apr 22, 2016 at 04:35:08PM +0300, Dmitry Safonov wrote:
>> On 04/22/2016 04:33 PM, Pavel Emelyanov wrote:
>>> On 04/20/2016 12:11 PM, Cyrill Gorcunov wrote:
>>>> Cyrill Gorcunov (2):
>>>>    build: install -- Add BINDIR var
>>>>    build: Add uninstall action
>>>>
>>>>   Documentation/Makefile |  6 +++++-
>>>>   Makefile.install       |  9 ++++++++-
>>>>   criu/Makefile          |  6 ++++++
>>>>   lib/Makefile           | 17 +++++++++++++++++
>>>>   4 files changed, 36 insertions(+), 2 deletions(-)
>>>>
>>> Dima, please, review.
>> Both looks good for me:
>> Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>
>>
>> Small note: maybe we should add new target to the help message.
> Thanks! Not sure I follow, what you mean by new target?
Something like this fixup (or anything alike):
--->8---
diff --git a/Makefile b/Makefile
index f470766c09f7..f849efcbaab4 100644
--- a/Makefile
+++ b/Makefile
@@ -300,6 +300,7 @@ help:
         @echo '      zdtm            - Build zdtm test-suite'
         @echo '      docs            - Build documentation'
         @echo '      install         - Install binary and man page'
+       @echo '      uninstall       - Uninstall binary and man page'
         @echo '      dist            - Create a source tarball'
         @echo '      clean           - Clean most, but leave enough to 
navigate'
         @echo '      mrproper        - Delete all compiled/generated files'



More information about the CRIU mailing list