[CRIU] [PATCH] criu: tty -- Restore tty params synchronously

Cyrill Gorcunov gorcunov at gmail.com
Thu Apr 21 11:02:11 PDT 2016


On Thu, Apr 21, 2016 at 08:48:49PM +0300, Pavel Emelyanov wrote:
> >>
> >> But the restore fails anyway, so we do we care?
> > 
> > Yes we care. The restoration of params must be done on alive terminals.
> 
> OK, but if terminal is dead, then the restore is failing. So why not
> have one more failure in logs?

Because in this case we don't control when real async ioctl is called,
as far as I understand we may hit it earlier and hide real case of
problem.

After all your questions, I started doubting if the changelog is correct.
For sure the reason of failure is async ioctl call over terminal
which is not alive (since with the patch container passes this point
of restore) but maybe I've overlooked something. Gimme some time...


More information about the CRIU mailing list