[CRIU] [PATCH v3 04/15] protobuf: add SysctlEntry for ipv4/ipv6 sysctl confs or some others

Pavel Emelyanov xemul at virtuozzo.com
Thu Apr 21 07:12:39 PDT 2016


> @@ -0,0 +1,7 @@
> +message sysctl_entry {
> +	/* CTL_32, __CTL_STR */
> +	required int32 type		= 1;

It seems to be bad practice to keep enums as ints. Better introduce the
protobuf enum for this.

> +
> +	optional int32 iarg		= 2;
> +	optional string sarg		= 3;
> +}
> 



More information about the CRIU mailing list