[CRIU] [PATCH 2/2] cg: Add ability to dump custom cgroup properties

Tycho Andersen tycho.andersen at canonical.com
Thu Apr 21 06:49:00 PDT 2016


On Thu, Apr 21, 2016 at 04:41:29PM +0300, Cyrill Gorcunov wrote:
> On Thu, Apr 21, 2016 at 04:31:55PM +0300, Pavel Emelyanov wrote:
> > How about this plan:
> > 
> > 1. s/json/yaml/
> > 2. s/hardcoded props/default props yaml file/
> > 
> > The 1st item would let us get rid of jansson library (yaml for the
> > sake of keeping list of props can be parsed by hands with the 
> > comparable amount of code). The 2nd would help us keep the list
> > of props up-to-date easier.
> > 
> > ?
> 
> I'm fine with either which allow us to specify custom props via
> command line. And sure I can rework for yaml. Except are you
> sure about yaml? Once done there won't be step back ;)

yaml is actually a strict superset of json, so you could write it in
json format if you wanted to, and a compliant yaml parser should parse
it correctly :)

r.e. the file, that sounds fine, if a pain to deal with in
development. Anyway, release will be today, so hopefully I can work
on an updated properties list next week. Cyrill I'll ping you to see
where you're at with this patch before I start.

Tycho


More information about the CRIU mailing list