[CRIU] [PATCH] restore: Wait for userns being prepared before moving into cgroups (v2)

[Cyrill Gorcunov]

On Thu, Apr 21, 2016 at 03:45:48PM +0300, Pavel Emelyanov wrote:
> On 04/21/2016 03:42 PM, Cyrill Gorcunov wrote:
> > On Thu, Apr 21, 2016 at 03:28:54PM +0300, Pavel Emelyanov wrote:
> >> The commit message doesn't match the patch itself.
> > 
> > These stages are used for completion.
> > 
> >>
> >>> @@ -213,7 +213,8 @@ static inline unsigned long restorer_stack(struct thread_restore_args *a)
> >>>  
> >>>  enum {
> >>>  	CR_STATE_FAIL		= -1,
> >>> -	CR_STATE_RESTORE_NS	= 0, /* is used for executing "setup-namespace" scripts */
> >>> +	CR_STATE_RESTORE_USERNS = 0,	/* restore uid_map and gid_map */
> >>> +	CR_STATE_RESTORE_NS,		/* is used for executing "setup-namespace" scripts */
> >>
> >> Why not merge it with CR_STATE_RESTORE_NS?
> > 
> > At least because it makes change more visible,
> 
> :\
> 
> > and moreover CR_STATE_RESTORE_NS already sync'ing
> > join-ns and such.
> 
> And... why not sync userns setup too?

As to me this look more convenient. But up to you and Andrew,
whatever works -- suits me just fine.