[CRIU] [PATCH 1/2] compel: Don't reclose files already closed

Cyrill Gorcunov gorcunov at gmail.com
Tue Apr 19 08:12:04 PDT 2016


On Tue, Apr 19, 2016 at 08:07:36AM -0700, Andrey Vagin wrote:
> On Tue, Apr 19, 2016 at 11:07:08AM +0300, Cyrill Gorcunov wrote:
> > In case of error don't re-close files already closed.
> > 
> > https://github.com/xemul/criu/issues/148
> > 
> > Reported-by: Andrew Vagin <avagin at virtuozzo.com>
> > Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> > +	if (fout)
> > +		fclose(fout);
> 
> fout is a global variable, so I think we need to set it to NULL here

It's safe by now, I'll be reworking this code soon.


More information about the CRIU mailing list