[CRIU] [PATCH 2/2] compel: Add missing 32s support

Cyrill Gorcunov gorcunov at gmail.com
Tue Apr 19 04:52:05 PDT 2016


On Tue, Apr 19, 2016 at 02:29:49PM +0300, Dmitry Safonov wrote:
> On 04/19/2016 02:25 PM, Dmitry Safonov wrote:
> >On 04/19/2016 11:07 AM, Cyrill Gorcunov wrote:
> >>https://github.com/xemul/criu/issues/148#issuecomment-211635122
> >Oh, sorry for that, I should have included this in my compat-patches:
> >https://github.com/0x7f454c46/criu/commit/a688402e2d3c659ebd2ee3b4cea3c2d1d10712de
> >
> >But I got that only after patches in the second part of compat series -
> >so planned to keep it in the second part.
> 
> To be correct - after this patch from the second part, which
> adds this kind of relocation:
> https://github.com/0x7f454c46/criu/commit/7f1eb57e9e376dacc83cb9f96ebe55c02768713a
> Before I didn't get this relocation on compile before it.

mov will produce absolute address which should be addressed
during relocation resolving, but I would rather stick with
lea and figure out why it get broken earlier?

> 
> >I'm fine with yours version,
> >Reviewed-by: Dmitry Safonov <dsafonov at virtuozzo.com>

Thanks!



More information about the CRIU mailing list