[CRIU] [PATCHv2 12/17] core/x86: add compatible 32 register set

Dmitry Safonov dsafonov at virtuozzo.com
Mon Apr 18 03:24:42 PDT 2016


On 04/18/2016 01:17 PM, Pavel Emelyanov wrote:
>> @@ -1,33 +1,40 @@
>>   import "opts.proto";
>>   
>> +enum user_x86_regs_case_t {
>> +	NATIVE = 1;
>> +	COMPAT = 2;
>> +}
>> +
>> +/* Reusing entry for both 64 and 32 bits register sets */
>>   message user_x86_regs_entry {
>> -	required uint64			r15		=  1;
>> -	required uint64			r14		=  2;
> ...
>> +	required user_x86_regs_case_t	gpregs_case	=  1;
>> +	required uint64			r15		=  2;
> ...
>>   }
> You cannot change field numbers in proto files w/o breaking backward
> compatibility.
>
> -- Pavel
>
Ok, so I will make gpregs_case the last member of
user_x86_regs_entry. Seems like, I also should make it
`optional`, so images made before could be read after
the patch. Right?

-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list