[CRIU] [PATCH] ppc64le: fix build with UFFD

Andrew Vagin avagin at virtuozzo.com
Tue Apr 12 11:21:55 PDT 2016


On Tue, Apr 12, 2016 at 08:52:29PM +0300, Mike Rapoport wrote:
> The __u64 is 'unsigned long' on Power and 'unsigned long long' on x86_64.
> Using PRI?64 does not help because, for instance, PRIu64 is 'lu'.
> 
> According to [1] the solution is to define __SANE_USERSPACE_TYPES__ for
> Power builds
> 
> [1] http://thread.gmane.org/gmane.linux.kernel/1425475/focus=1427433
> 
> Signed-off-by: Mike Rapoport <rppt at linux.vnet.ibm.com>
> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index e22c71e..625cf31 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -67,7 +67,7 @@ ifeq ($(ARCH),ppc64)
>                  error := $(error ppc64 big endian not yet supported)
>          endif
>  
> -        DEFINES		:= -DCONFIG_PPC64
> +        DEFINES		:= -DCONFIG_PPC64 -D__SANE_USERSPACE_TYPES__

I think the same problem exists for arm and aarch64.

Can we define __SANE_USERSPACE_TYPES__ for all arch-es and remove
PRI*64 from code?

Thanks,
Andrew

>  endif
>  
>  export PROTOUFIX DEFINES USERCFLAGS
> -- 
> 1.9.1
> 


More information about the CRIU mailing list