[CRIU] [PATCH 06/15] build/nmk: bring gen-rule-* back
Dmitry Safonov
dsafonov at virtuozzo.com
Tue Apr 12 02:48:19 PDT 2016
On 04/11/2016 10:23 PM, Cyrill Gorcunov wrote:
> On Mon, Apr 11, 2016 at 03:19:20PM +0300, Dmitry Safonov wrote:
>> Firstly, I think that way is more descriptive, but basically I used
>> them in my -obj-uniq, -lib-uniq rules (next patch) before they left.
>>
>> Signed-off-by: Dmitry Safonov <dsafonov at virtuozzo.com>
> Can we please don't do that? Together with the next patch, where
> one source needed for different targets? I've been there:
> simply make a symlink to existing file with new name, and
> use it instead.
>
> Moreover, we already do that: for example
>
> pie-util-vdso.c -> pie/util-vdso.c
>
> for exactly same reason -- same source but different
> compile flags.
Yeah, I didn't think about that possibility - that will be simpler,
will rework this part to use links.
Thanks for the review!
--
Regards,
Dmitry Safonov
More information about the CRIU
mailing list