[CRIU] [PATCH] criu: x86 -- Drop @ds test from compat mode

Dmitry Safonov dsafonov at virtuozzo.com
Wed Apr 6 09:57:08 PDT 2016


On 04/06/2016 05:33 PM, Cyrill Gorcunov wrote:
> On Wed, Apr 06, 2016 at 04:25:21PM +0200, Federico Reghenzani wrote:
>>     Ok, I patched CRIU, I tried 3 times and it works but I have to test
>>     further, I'll update you has soon of possible (probably tomorrow or
>>     friday).
>>     Thanks for your really fast patch :)
> Thank you! Actaully I really wonder who needs null selector -- any attempts
> to dereference is will cause #gp. So the question is that -- is there something
> screwed by CRIU restore procedure, or the program indeed zeroifies @ds register.

Hmm, just FYI, I reworked this part in compatible patches set.
It will check iov.iov_len, returned by PTRACE_GETREGSET.
(It depends on compatible thread flag)
The same approach uses strace from 4.8 version:
https://sourceforge.net/projects/strace/files/strace/4.8/

So, this will be good, when patches set will made it's way to master.

-- 
Regards,
Dmitry Safonov



More information about the CRIU mailing list