[CRIU] [PATCH 0/4] add join-ns option to criu restore

[Pavel Emelyanov]

On 04/06/2016 01:43 PM, Dengguangxing wrote:
> 
> 
> 在 2016/4/6 17:55, Pavel Emelyanov 写道:
>> Yup, applied to criu-dev, thanks.
>>
>> I have a question regarding patch #4 (with test):
>>
>>> @@ -1226,6 +1231,14 @@ def run_tests(opts):
>>>  		print "Parallel launch with freezer not supported"
>>>  		opts['parallel'] = None
>>>
>>> +	if opts['join_ns']:
>>> +		print "[WARNING] Option --join-ns will skip ns and uns flavors, and some socket related tests."
>>> +		r = re.compile('^(?!.*sock).*$')
>>> +		torun = filter(lambda x: r.match(x), torun)
>>> +		opts['keep_going'] = True
>>> +		run_all = True
>>> +		subprocess.Popen(["ip", "netns", "add", "zdtm_netns"])
>>> +
>>>  	l = launcher(opts, len(torun))
>>>  	try:
>>>  		for t in torun:
>>
>> Why do you exclude all sock tests from --join-ns run?
>>
> join-ns zdtm run with network namespace, and sock tests would fail because the former
> networknamespace is deprecated.

But not all of them should. E.g. tests with unix sockets should continue working,
tests with tcp listening sockets only should work.

Would you check what exact tests fail and why?

-- Pavel