[CRIU] [PATCH 04/12] p.haul: add parsing of shared disk string

Nikita Spiridonov nspiridonov at virtuozzo.com
Tue Apr 5 02:47:40 PDT 2016


Acked-by: Nikita Spiridonov <nspiridonov at virtuozzo.com>

On Fri, 2016-04-01 at 18:45 +0300, Alexander Burluka wrote:
> Signed-off-by: Alexander Burluka <aburluka at virtuozzo.com>
> ---
>  phaul/fs_haul_ploop.py | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/phaul/fs_haul_ploop.py b/phaul/fs_haul_ploop.py
> index 61c7465..63c2a64 100644
> --- a/phaul/fs_haul_ploop.py
> +++ b/phaul/fs_haul_ploop.py
> @@ -76,6 +76,11 @@ class p_haul_fs:
>  			self.__ploop_copies.append(
>  				libploop.ploopcopy(ddxml_path, delta_fd))
>  
> +	def __parse_shared_ploops(self, shareds):
> +		if not shareds:
> +			return []
> +		return (get_ploop_delta_abspath(s, self.__ct_priv) for s in shareds.split(","))
> +

Minor - p_haul_vz already contain args parsing logic
(phaul_iter_worker.__parse_fdfs_arg). It is better to encapsulate fs
related args parsing logic in single module (p_haul_vz or
fs_haul_ploop). This can be done in further patches.

>  	def set_options(self, opts):
>  		pass
>  




More information about the CRIU mailing list