[CRIU] [PATCH CRIU 02/14] net/ipv4: suffix configs with "4"

Pavel Tikhomirov ptikhomirov at virtuozzo.com
Mon Apr 4 03:39:37 PDT 2016



On 04/04/2016 01:10 PM, Pavel Emelyanov wrote:
>> diff --git a/images/netdev.proto b/images/netdev.proto
>> index dafa2bd..7d7bb26 100644
>> --- a/images/netdev.proto
>> +++ b/images/netdev.proto
>> @@ -30,10 +30,10 @@ message net_device_entry {
>>
>>   	optional bytes address		= 7;
>>
>> -	repeated int32 conf		= 8;
>> +	repeated int32 conf4		= 8;
>>   }
>>
>>   message netns_entry {
>> -	repeated int32 def_conf		= 1;
>> -	repeated int32 all_conf		= 2;
>> +	repeated int32 def_conf4	= 1;
>> +	repeated int32 all_conf4	= 2;
>>   }
>>
>
> Image descriptions are append-only.

I thought renaming fields in protobuf are fine, I tested forward 
compatibility and ipv4 confs were restored fine. (I make these rename to 
empathize that net_conf_op can take both v4/v6 confs and to make code 
look more understandable)

>

-- 
Best regards, Tikhomirov Pavel
Software Developer, Virtuozzo.


More information about the CRIU mailing list