[CRIU] [PATCH] pie: open_detach_mount -- Use pr_perror for regular build

[Dmitry Safonov]

On 04/04/2016 12:22 PM, Cyrill Gorcunov wrote:
> On Mon, Apr 04, 2016 at 12:09:36PM +0300, Dmitry Safonov wrote:
>> -#ifndef CR_NOGLIBC
>> +#ifdef CR_NOGLIBC
>> +
>> +#define pr_perror(fmt, ...)                                            \
>> +       pr_err(fmt "\n", ##__VA_ARGS__)
>> +
>> +#else
>>
>>   #define pr_perror(fmt, ...)                                            \
>>          pr_err(fmt ": %s\n", ##__VA_ARGS__, strerror(errno))
> The problem is that pr_perror always prints errno, and here
> I named helpers with two underscope prefix on purpose. Plain
> pr_perror I think might be confusing. But it's question of
> taste so up to you and Pasha, I don't have strong opinion.
Ok, I don't have a strong opinion either - just suggested,
as it seems to me better not to have such helpers, but
do it some generic way. But I think, it may be misleading,
as you mentioned, so I just gave an idea and I'm fine
with either version.