[CRIU] [PATCH] fsmptify: Filter out internal inotify bits when restoring marks

Andrew Vagin avagin at odin.com
Wed Sep 23 05:00:57 PDT 2015


On Tue, Sep 22, 2015 at 05:21:42PM +0300, Cyrill Gorcunov wrote:
> On Tue, Sep 22, 2015 at 04:48:40PM +0300, Andrew Vagin wrote:
> > > 
> > > You miss the point. It was a bug in the kernel that it has been exporting
> > > internal bit into userspace. The kernel has _all_ rights to
> > > 
> > > #define IN_SOME_NEW_BIT	 	0x08000000
> > 
> > Now I'm agree that my idea isn't good, but I don't like to use
> > IN_ALL_EVENTS too :-P
> 
> I understand that. By using IN_ALL_EVENTS we are limiting criu
> and make it bound to the environment it has been built on.
> So, maybe don't patch criu at all? I thought we're failing in
> the tests actually.

An user can dump processes on an old kernel and then restore them on
a new one. We don't check this case in our tests.


More information about the CRIU mailing list