[CRIU] v3 of the sysctl patchset

Tycho Andersen tycho.andersen at canonical.com
Mon Sep 21 07:03:47 PDT 2015


On Mon, Sep 21, 2015 at 03:42:58PM +0300, Andrew Vagin wrote:
> On Wed, Sep 16, 2015 at 09:02:35PM -0600, Tycho Andersen wrote:
> > Hi all,
> > 
> > Here's v3 of the set. It turns out that the sysctl "namespacing" bits are not
> > at all similar, so how you restore things depends on which namespace the sysctl
> > files are members of. Anyway, hopefully the last patch isn't too ugly :)
> 
> Can we enable CLONE_NEWUTS and CLONE_NEWIPC for zdtm tests?

Seems like we should be able to, I didn't know about this flag. When I
resend I'll enable that as well, thanks.

Tycho

> diff --git a/test/zdtm/lib/ns.c b/test/zdtm/lib/ns.c
> index ecf1e0c..07cfd6b 100644
> --- a/test/zdtm/lib/ns.c
> +++ b/test/zdtm/lib/ns.c
> @@ -406,8 +406,8 @@ void ns_create(int argc, char **argv)
>                  * CLONE_NEWIPC and CLONE_NEWUTS are excluded, because
>                  * their sysctl-s are protected by CAP_SYS_ADMIN
>                  */
> -               flags = CLONE_NEWPID | CLONE_NEWNS  |
> -                       CLONE_NEWNET | CLONE_NEWUSER | SIGCHLD;
> +               flags = CLONE_NEWPID | CLONE_NEWNS |
> +                       CLONE_NEWNET | CLONE_NEWIPC | CLONE_NEWUSER | SIGCHLD;
>         else
>                 flags = CLONE_NEWPID | CLONE_NEWNS | CLONE_NEWUTS |
>                         CLONE_NEWNET | CLONE_NEWIPC | SIGCHLD;
> > 
> > Tycho
> > 
> > _______________________________________________
> > CRIU mailing list
> > CRIU at openvz.org
> > https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list