[CRIU] [PATCH] cr-super: Initial commit

Pavel Emelyanov xemul at parallels.com
Wed Sep 16 07:44:01 PDT 2015


On 09/16/2015 05:36 PM, Andrew Vagin wrote:
> On Wed, Sep 16, 2015 at 05:22:07PM +0300, Andrew Vagin wrote:
>> On Wed, Sep 16, 2015 at 04:43:21PM +0300, Cyrill Gorcunov wrote:
>>> On Wed, Sep 16, 2015 at 02:55:09PM +0300, Andrew Vagin wrote:
> ...
>>>
>>> and that's all. Probably merging open-dir with get-stat
>>> is a good idea. Thanks for the note.
>>>
>>> Same time for auif it might endup in
>>>
>>> 	-> opendir
>>> 	<- ok
>>> 	-> get-stat
>>> 	<- ok
>>> 	-> read-link (huge size)
>>> 	<- ok
>>> 	-> parse mnt-id
>>> 	<- ok
>>
>> It may be very slow to request informatiosn about each mappings
>> separatly. Maybe we can open /proc/PID/map_files/XXXX and send the file
>> descriptor back?
>>
> 
> we need to open files with O_PATH, because an user may not be able to
> write or read in this file.

I tend to agree. Using O_PATH-ed file we can stat it, get mnt_id and
resolve path. The only thing we cannot do is read file contents to
dump mapped and unlnked file, but for this (quite rare) case we can
ask the cr-super again.

-- Pavel



More information about the CRIU mailing list