[CRIU] [PATCH 5/7] mount: mounts_equal -- Fix comment and a few style nits

Cyrill Gorcunov gorcunov at gmail.com
Thu Sep 3 03:53:44 PDT 2015


On Thu, Sep 03, 2015 at 01:44:01PM +0300, Andrew Vagin wrote:
> 
> 1.
> 	if (strcmp(c->root, mi->root))
> 		return false;
> 	if (strcmp(basename(c->mountpoint), basename(mi->mountpoint)))
> 		return false;
> 
> 2.
> 	if (strcmp(c->root, mi->root)		||
> 	    strcmp(basename(c->mountpoint),
> 		   basename(mi->mountpoint)))
> 		return false;
> 
> I like the first version...

Up to you. Feel free to drop.


More information about the CRIU mailing list