[CRIU] [PATCH 0/3] mount: Improve restore of deleted bindmounts

Cyrill Gorcunov gorcunov at gmail.com
Wed Sep 2 05:42:09 PDT 2015


On Wed, Sep 02, 2015 at 03:35:40PM +0300, Pavel Emelyanov wrote:
> 
> If directory exists, then mkdir() would fail. But if file exists open()
> would not fail. But it probably should, how about adding O_EXCL to flags?
> 
> And question number 2 -- is it good or bad that we leak a file descriptor
> after open()?

You're right in both cases -- we should fail if the fail exist because
it must not, and of course we shouldn't leak file descriptor here.
Will fix and send, thank you!

	Cyrill


More information about the CRIU mailing list